Fix manual is multiple of #15205
Merged
Fix manual is multiple of #15205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, if they appear within the context of a function argument, they will be marked as certain, as they might eventually be considered `i32` by default if the context is not more specific. Also, in the case of binary expressions, if one of the side is uncertain, then the certainty will come from the other side.
`Node::Param(…)` can represent function parameters as well as closure parameters. In the second case, a type is not always given. When no type is given, consider it uncertain.
- `&a % &b == 0` compiles, but requires dereferencing `b` when replacing with `a.is_multiple_of(b)`. - In `a % b == 0`, if type of `a` is not certain, `a.is_multiple_of(b)` might not be typable. - In `a % b == 0`, `a` and `b` must be unsigned integers, not any arbitrary types implementing `Rem` and outputing an integer.
Collaborator
rustbot
added
the
S-waiting-on-review
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
the
beta-nominated
Member
Author
rustbot
removed
the
beta-nominated
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several issues with
manual_is_multiple_of&a % &b == 0compiles, but requires dereferencingbwhen replacing witha.is_multiple_of(b).a % b == 0, if type ofais not certain,a.is_multiple_of(b)might not be typable.a % b == 0,aandbmust be unsigned integers, not any arbitrary types implementingRemand outputing an integer.Those fixes have required increasing the precision of type certainty determination in the two first patches.
Fixes #15203
Fixes #15204
changelog: [
manual_is_multiple_of]: fix various false positive