Skip to content

Fix needless_range_loop FP on array literals #15314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix needless_range_loop FP on array literals #15314

merged 1 commit into from
Jul 19, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jul 19, 2025 •
edited by rustbot
Loading

Closes #15309

changelog: [needless_range_loop] fix FP on array literals

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2025
llogiq
llogiq reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small simplification, this looks mergeworthy.

@profetia profetia requested a review from llogiq July 19, 2025 11:32
@llogiq
Copy link
Contributor

llogiq commented Jul 19, 2025

Thank you!

@llogiq llogiq added this pull request to the merge queue Jul 19, 2025
Merged via the queue into rust-lang:master with commit 17968e7 Jul 19, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2025
@profetia profetia deleted the issue15309 branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llogiq llogiq Awaiting requested review from llogiq

Assignees

@llogiq llogiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

needless_range_loop doesn't recognize anonymous arrays

3 participants

@profetia @rustbot @llogiq