Skip to content

Conversation

alex-semenyuk
Copy link
Member

Noticed that after #15315 we don't show deprecated lints at all
Take to account we don't count them at total after #14948 and we don't show them after #15315 perhaps we don't need to show them as well as filters for them so make a cleanup
Screenshot 2025-08-02 at 14 20 34

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 2, 2025
@samueltardieu
Copy link
Member

r? @Alexendoo because of #15315

@rustbot rustbot assigned Alexendoo and unassigned samueltardieu Aug 2, 2025
@alex-semenyuk alex-semenyuk changed the title Remove Deprecated lints mentioned Remove Deprecated lints mention Aug 3, 2025
@flip1995
Copy link
Member

flip1995 commented Aug 4, 2025

I'd say not showing deprecated lints in the lint list is a bug, rather than a feature 🤔

@alex-semenyuk
Copy link
Member Author

Make sense, we can back it. Show Total number - active and deprecated for consistency

@samueltardieu
Copy link
Member

We should show deprecated lints so that people can see they exist(ed), but I don't think we should count them, it makes little sense to count lints that have been uplifted to rustc for example, as they aren't maintained in Clippy anymore. That was what #14948 was about.

@Alexendoo
Copy link
Member

Ah right None was for deprecated lints, in that case I think just reverting #15315 would be fine, I don't think we need to do anything extra

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 4, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 4, 2025
As discussed at #15387 revert changes
#15315 to show deprecated.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants