Skip to content

move char_lit_as_u8 under the explicit-cast case #15477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

move char_lit_as_u8 under the explicit-cast case #15477

merged 3 commits into from
Aug 13, 2025

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 13, 2025

allows reusing cast_from_expr and cast_to

also make the test files a bit more.. standard

changelog: none

ada4a added 3 commits August 13, 2025 16:33
@ada4a
test: move the main file to unfixable
ad9686e 
since it's the one that makes no suggestions
@ada4a
test: make suggestions the main file
ff2b5e6 
since it's the one that has suggestions
@ada4a
move char_lit_as_u8 into the if
e6f3cb0 
allows reusing `cast_from_expr` and `cast_to`
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
Jarcho
Jarcho approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Aug 13, 2025
Merged via the queue into rust-lang:master with commit 6659540 Aug 13, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
@ada4a ada4a deleted the char-lit-as-u8 branch August 13, 2025 17:30
@ada4a ada4a mentioned this pull request Aug 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ada4a @rustbot @Jarcho