Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 13, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
@ada4a ada4a force-pushed the ptr-cast-constness-cleanup branch from 0346fca to 11ef9e6 Compare August 13, 2025 17:34
@ada4a ada4a force-pushed the ptr-cast-constness-cleanup branch from 11ef9e6 to a9883fd Compare August 22, 2025 13:35
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if squashed

use `Mutability::ptr_str`

replace `matches!` with an equality check

avoid always allocating a `String`

s/cast_expr/cast_from_expr -- for more consistency with the naming in `mod.rs`
@ada4a ada4a force-pushed the ptr-cast-constness-cleanup branch from a9883fd to 0e5b1b1 Compare August 24, 2025 06:29
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Aug 24, 2025

@rustbot ready

@samueltardieu samueltardieu added this pull request to the merge queue Aug 24, 2025
Merged via the queue into rust-lang:master with commit f6c7786 Aug 24, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2025
@ada4a ada4a deleted the ptr-cast-constness-cleanup branch August 24, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants