Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 24, 2025

As discussed in #clippy > #15035

Fixes #15035

changelog: [unused_unit] don't lint on closure return types

@ada4a ada4a marked this pull request as ready for review August 24, 2025 08:33
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2025
Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you submit the first two commits (with the proposed change) as a separate PR assigned to me? The third commit (removing -> ()) might need discussion, while the first two are non-controversial.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 24, 2025
@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@samueltardieu
Copy link
Member

Discussion on https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/.2315035/with/535865672, thanks for starting the thread there @ada4a.

@samueltardieu samueltardieu added this pull request to the merge queue Aug 25, 2025
Merged via the queue into rust-lang:master with commit 798f754 Aug 25, 2025
11 checks passed
@ada4a ada4a deleted the unused_unit branch August 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unused_unit false positive when removing -> () leads to type inference failure

3 participants