Skip to content

unit_cmp: don't lint on explicitly written unit expr #15562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

unit_cmp: don't lint on explicitly written unit expr #15562

merged 1 commit into from
Aug 27, 2025

Conversation

zihan0822
Copy link
Contributor

@zihan0822 zihan0822 commented Aug 26, 2025 •
edited by rustbot
Loading

Fixes #15559

changelog: [unit_cmp]: don't lint on explicitly written unit expr

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 26, 2025
samueltardieu
samueltardieu requested changes Aug 26, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, otherwise it looks fine!

r? samueltardieu
@rustbot author

@rustbot rustbot assigned samueltardieu and unassigned blyxyas Aug 26, 2025
@samueltardieu samueltardieu added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@samueltardieu samueltardieu mentioned this pull request Aug 26, 2025
Merged
@zihan0822
unit_cmp: don't lint on explicitly written unit expr
bb8ba69 
changelog: [`unit_cmp`]: don't lint on explicitly written unit expr

Signed-off-by: Zihan <zihanli0822@gmail.com>
@zihan0822
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2025
@blyxyas
Document is_unit_expr() (#15571)
9121dcc 
Noticed when reviewing #15562.
Part of #15569.

changelog: none
@samueltardieu
Copy link
Member

Thanks.

@samueltardieu samueltardieu added this pull request to the merge queue Aug 27, 2025
Merged via the queue into rust-lang:master with commit f982b48 Aug 27, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2025
@zihan0822 zihan0822 deleted the explicit-unit-cmp branch August 28, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unit_cmp: don't lint on explicitly written units

4 participants

@zihan0822 @rustbot @samueltardieu @blyxyas