Skip to content

Conversation

@lukaslueg
Copy link
Contributor

@lukaslueg lukaslueg commented Sep 18, 2025

Fixes #15404

changelog: [result_large_err]: Add large_error_ignored configuration

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@dswij
Copy link
Member

dswij commented Oct 6, 2025

r? clippy

@rustbot rustbot assigned llogiq and unassigned dswij Oct 6, 2025
@rustbot

This comment has been minimized.

@llogiq
Copy link
Contributor

llogiq commented Nov 14, 2025

I don't see anything wrong with this approach. r=me after a rebase.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lukaslueg
Copy link
Contributor Author

@llogiq, can one still use r=... with the new merge queue? In any case: rebased.

@llogiq llogiq added this pull request to the merge queue Nov 23, 2025
@llogiq
Copy link
Contributor

llogiq commented Nov 23, 2025

I can r=me whatever I want. I still have to merge manually.

Merged via the queue into rust-lang:master with commit 3efb2ac Nov 23, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 23, 2025
@lukaslueg lukaslueg deleted the issue15404 branch November 23, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

result_large_err difficult to suppress selectively

5 participants