You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of the 5 lints in the derive directory, only two of them (unsafe_derive_deserialize and derive_partial_eq_without_eq) posted the lint on the ADT node. This fixes the situation for the three other lints:
derived_hash_with_manual_eq
derive_ord_xor_partial_ord
expl_impl_clone_on_copy
This allows #[expect] to be used on the ADT to silence the lint.
Also, this makes expl_impl_clone_on_copy properly use an "help" message instead of a "note" one when suggesting a fix.
changelog: [derived_hash_with_manual_eq]: honor the use of #[expect] on the type to which the lint applies
changelog: [derive_ord_xor_partial_ord]: honor the use of #[expect] on the type to which the lint applies
changelog: [expl_impl_clone_on_copy]: honor the use of #[expect] on the type to which the lint applies
Oh, I was trying to do basically this for #13356, which complains about the particular case of derived_hash_with_manual_eq, so that issue can be closed as well.
Speaking of that lint, you have a small typo in its name -- derive instead of derived. Although the other lints use derive, and one could argue that that sounds more natural -- maybe this lint should be renamed?
Oh, I was trying to do basically this for #13356, which complains about the particular case of derived_hash_with_manual_eq, so that issue can be closed as well.
Speaking of that lint, you have a small typo in its name -- derive instead of derived. Although the other lints use derive, and one could argue that that sounds more natural -- maybe this lint should be renamed?
I fixed the typo, thanks. Yeah, it should probably be renamed, but not in this PR though. I'll note that #13356 will be closed as well.
The reason will be displayed to describe this comment to others. Learn more.
…and here
rustbot
added
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
labels
Sep 19, 2025
Out of the 5 lints in the `derive` directory, only two of them
(`unsafe_derive_deserialize` and `derive_partial_eq_without_eq`) posted
the lint on the ADT node. This fixes the situation for the three other
lints:
- `derive_hash_with_manual_eq`
- `derive_ord_xor_partial_ord`
- `expl_impl_clone_on_copy`
This allows `#[expect]` to be used on the ADT to silence the lint.
Also, this makes `expl_impl_clone_on_copy` properly use an "help" message
instead of a "note" one when suggesting a fix.
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
and removed
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
labels
Sep 21, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
issues/15708
branch
from
Out of the 5 lints in the
derivedirectory, only two of them (unsafe_derive_deserializeandderive_partial_eq_without_eq) posted the lint on the ADT node. This fixes the situation for the three other lints:derived_hash_with_manual_eqderive_ord_xor_partial_ordexpl_impl_clone_on_copyThis allows
#[expect]to be used on the ADT to silence the lint.Also, this makes
expl_impl_clone_on_copyproperly use an "help" message instead of a "note" one when suggesting a fix.Fixes #15708
Fixes #13356
changelog: [
derived_hash_with_manual_eq]: honor the use of#[expect]on the type to which the lint applieschangelog: [
derive_ord_xor_partial_ord]: honor the use of#[expect]on the type to which the lint applieschangelog: [
expl_impl_clone_on_copy]: honor the use of#[expect]on the type to which the lint applies