Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on latest nightly #1619

Merged
merged 2 commits into from
Mar 13, 2017
Merged

Conversation

Techcable
Copy link
Contributor

@Techcable Techcable commented Mar 13, 2017

The ability for plugins to add MIR passes was removed as of 4ca9c97.
Luckily, we don't use this feature at all and can safely ignore it.

Fixes #1618

Although it successfully lints itself and several other projects, it doesn't pass the tests because the compiler keeps panicking 🙄

The ability for plugins to add MIR passes was removed as of 4ca9c97.
Luckily, we don't use this feature at all and can safely ignore it.

Fixes rust-lang#1618
@oli-obk
Copy link
Contributor

oli-obk commented Mar 13, 2017

That's weird. Dogfood fails on appveyor but not on travis

error: adding items after statements is confusing, since items exist from the start of the scope
   --> clippy_lints/src\assign_ops.rs:130:25
    |
130 |                         macro_rules! ops {
    |                         ^
    |
    = note: `-D items-after-statements` implied by `-D clippy-pedantic`
    = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#items_after_statements
error: adding items after statements is confusing, since items exist from the start of the scope
   --> clippy_lints/src\doc.rs:246:5
    |
246 |     macro_rules! check_block {
    |     ^
    |
    = note: `-D items-after-statements` implied by `-D clippy-pedantic`
    = help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#items_after_statements
error: aborting due to 2 previous errors

@oli-obk
Copy link
Contributor

oli-obk commented Mar 13, 2017

Anyway... macro_rules! is order dependent within statements. So we should fix that lint.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 13, 2017

macro_rules breakage from rust-lang/rust#40220

Still no idea why travis works... I reran it to check whether it has an outdated rustc, but it worked fine all over again...

@oli-obk oli-obk merged commit d77dc1f into rust-lang:master Mar 13, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Mar 13, 2017

Thanks! publishing now

@pwrdwnsys
Copy link

v0.0.119 compiled successfully on macOS with rustc 1.17.0-nightly (824c9eb 2017-03-12)

@Techcable Techcable deleted the fix/mir_passes branch March 13, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants