Skip to content

Enhance needless_collect to cover vec push-alike #16305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
profetia wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enhance needless_collect to cover vec push-alike #16305

profetia wants to merge 3 commits into from
+474 −16

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 28, 2025 •
edited by rustbot
Loading

Closes #14946

Implemented as an enhancement to needless_collect

changelog: [needless_collect] enhance to cover vec push-alike cases

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 28, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@profetia profetia changed the title Enhance needless_collect to cover vec push Enhance needless_collect to cover vec push-alike Dec 28, 2025
llogiq
llogiq reviewed Jan 1, 2026
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve the suggestion, but otherwise this looks good. Let me know if you want to do the suggestion improvement on this PR or I'll merge it and we can do a followup.

View changes since this review

@profetia profetia requested a review from llogiq January 2, 2026 00:16
@profetia
Copy link
Member Author

profetia commented Jan 2, 2026

Emm.., I just realize that push_front can also be handled. I will cover it in this PR.

llogiq
llogiq reviewed Jan 2, 2026
View reviewed changes
tests/ui/needless_collect.stderr
Comment on lines +222 to +230
LL ~
LL |
LL ~
LL ~
LL ~
LL ~
LL ~
LL ~
LL ~
Copy link
Contributor

@llogiq llogiq Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this? Empty spans perhaps?

Copy link
Member Author

@profetia profetia Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pushs are removed in the suggestions, leaving these empty lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llogiq llogiq llogiq left review comments

Assignees

@llogiq llogiq

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion of collect_push_then_iter for iterators

3 participants

@profetia @rustbot @llogiq