clean tests/ui/assign_ops.rs #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all //~ were removed from tests, these were replaced with empty lines to leave the numbers in the expected stderr untouched. Cleaning the empty lines for clarity.
|
Thanks! This is a good idea. You can probably just throw rustfmt on the tests (except those which care about formatting xD) |
|
@oli-obk cool! Will add an issue and assign it to myself. No idea why the Travis checks failed |
Closed
because compiletest_rs updated to the "latest nightly", which doesn't exist -.- |
|
woot! All checks passed. @oli-obk, thanks for re-triggering the tests. |
|
Great! took a few tries xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all //~ were removed from tests, these were replaced with empty
lines to leave the numbers in the expected stderr untouched.
Cleaning the empty lines for clarity.
If there is interest, I could slowly do the rest of the test files that have weird looking empty files. Happy to do so 😄, the clone() lint I have assigned is taking me a bit more time of research.