Fix tests. #1873
Merged
Fix tests. #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test outputs.
oli-obk
reviewed
Jul 5, 2017
clippy_tests/examples/range.rs
Outdated
| @@ -29,7 +21,4 @@ fn main() { | |||
| let v2 = vec![4,5]; | |||
| let _x = v1.iter().zip(0..v1.len()); | |||
| let _y = v1.iter().zip(0..v2.len()); // No error | |||
|
|
|||
| // check const eval | |||
| let _ = v1.iter().step_by(2/3); | |||
There was a problem hiding this comment.
You should leave these in, since they use the Iterator::step_by feature
There was a problem hiding this comment.
Sorry, that wasn't very clear... I meant to leave all the calls to step_by in the tests. At least those that compile.
There was a problem hiding this comment.
I want to do so, but directly passing -1 or 0 to step_by causes a compile error immediately, which will suppress the clippy warnings. I don't think that's what we expected.
There was a problem hiding this comment.
I'm sorry for it. step_by(0) in tests is ok. I'll put them back.
|
Great! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1872.