Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilizing feature iterator_for_each for rust 1.22.0 #2051

Closed
wants to merge 1 commit into from

Conversation

budziq
Copy link
Contributor

@budziq budziq commented Sep 14, 2017

It's my first rust stabilization PR and it's with submodules to boot so might have done something completely wrong. Sorry for that!

@budziq budziq changed the title stabilizing feature iterator_for_each for rust 1.21.0 stabilizing feature iterator_for_each for rust 1.22.0 Sep 14, 2017
@budziq
Copy link
Contributor Author

budziq commented Sep 15, 2017

I guess that this change might go to a separate branch until rust-lang/rust#44567 is merged as was the case for identical PR for RLS. Please let me know if any additional action is needed on my part.

edit: the iterator_for_each stabilization is merged!

@Manishearth
Copy link
Member

retriggering travis

@Manishearth
Copy link
Member

ah, looks like a test needed updated line numbers. fixed.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 29, 2017

@Manishearth you forgot to push your fixes

@Manishearth
Copy link
Member

Fix was 04c44fa, looks like I landed it and this PR directly as 44ecc19 . Probably did a rebase and forgot to update the PR. It's merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants