Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint for opt.map_or(None, f) #2128

Merged
merged 3 commits into from
Oct 10, 2017
Merged

Add lint for opt.map_or(None, f) #2128

merged 3 commits into from
Oct 10, 2017

Commits on Oct 10, 2017

  1. Add lint for opt.map_or(None, f) 

    Change to Warn and add multiline support

Fix typo

Update reference
    @lukasstevens
    lukasstevens committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    eb53cca View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary borrow

    @lukasstevens
    lukasstevens committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    c0fac7c View commit details
    Browse the repository at this point in the history

  3. Make suggested changes 

    - Fix copy-paste error
- Check for opt.map_or argument after ensuring that opt is an Option
- Use span_lint_and_then and span_suggestion
- Update reference
    @lukasstevens
    lukasstevens committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    4438c41 View commit details
    Browse the repository at this point in the history