Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation for nightly 2018-04-06 #2640

Merged
merged 1 commit into from Apr 7, 2018
Merged

Fix compilation for nightly 2018-04-06 #2640

merged 1 commit into from Apr 7, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2018

Fixes breakages introduced by rust pull request 'AST: Give spans to all identifies' - rust-lang/rust#49154

Closes #2639

Breakages for introduced by rust pull request
'AST: Give spans to all identifies' - rust-lang/rust/pull#49154

Closes #2639
@ghost
Copy link
Author

ghost commented Apr 7, 2018

The build failed with some weird warnings. I might have broken the needless_borrow lint.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 7, 2018

I don't see how you could have broken it, your changes are flawless. I'll merge it for now and fix it locally before publish.

@oli-obk oli-obk merged commit a863ba1 into rust-lang:master Apr 7, 2018
@ghost ghost deleted the fix_compilation_20180406 branch April 17, 2018 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant