-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581 #3072
Conversation
Why? Just run the tests from this repo? If you need a rustc to run this with, use https://github.com/kennytm/rustup-toolchain-install-master ( |
Ok, I got it to build but a lot of tests fail, it looks like run-pass chooses the wrong compiler (nightly instead of master) 🤷♂️ |
AAAAH the I removed it for testing, and all tests pass except for dogfood
|
(However since clippy compiled fine I assume that dogfood failure is only due to me using the rustc master version wrongly) |
Have you tried |
Ok, I found my mistake, all tests pass now 🎉 |
Warning was: warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable --> src/lib.rs:4:12 | 4 | #![feature(macro_vis_matcher)] | ^^^^^^^^^^^^^^^^^ | = note: #[warn(stable_features)] on by default
Thanks, the tool_attributes feature stabilization was merged a few hours ago. I added that here. All tests pass for me locally |
Is there a way to run the tests from the rustc repos clippy_lints package?