New lint: Unknown clippy lints #3161

flip1995 · 2018-09-10T15:30:35Z

This is the Clippy version of the rustc lint unknown_lints. The behavior of this lint is pretty much the same.

Before this is merged a small change in the compiler needs to be done: CheckLintNameResult needs to be public. See rust-lang/rust#54106

oli-obk · 2018-09-10T15:39:04Z

clippy_lints/src/attrs.rs

+            if let CheckLintNameResult::Tool(Err((None, _))) = lint_store.check_lint_name(
+                &name.as_str(),
+                Some(tool_name.as_str()),
+                );


weird indent

oli-obk · 2018-09-10T15:39:15Z

clippy_lints/src/attrs.rs

+                    cx,
+                    UNKNOWN_CLIPPY_LINTS,
+                    lint.span,
+                    &format!("unknwon clippy lint: clippy::{}", name),


oli-obk · 2018-09-10T15:41:16Z

clippy_lints/src/attrs.rs

+                    |db| {
+                        if name.as_str().chars().any(|c| c.is_uppercase()) {
+                            let name_lower = name.as_str().to_lowercase().to_string();
+                            match lint_store.check_lint_name(


I'm guessing there's currently no way to manually iterate the list and do a levensthein search for close matches?

I don't think so. This is the behavior of the unknown_lints lint of the compiler. This could be an enhancement for this lint AND the compiler lint. (I'm not sure if the performance of this would be bad though)

We do have some tricks like checking whether a lint is allowed before doing the heavy work. But yea, we should fix this in the compiler first

There is lev_distance in the compiler.

I opened rust-lang/rust#54737 for improving the rustc unknown_lints suggestion.

I'm not sure when I get around to work on Rust's unknown_lints, I'm fine with merging this and creating an issue to improve the suggestions later on.

@Manishearth

…=Manishearth Reexport CheckLintNameResult Make the enum `CheckLintNameResult` public, so that lint tools (aka Clippy) can use it together with [`LintStore::check_lint_name`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/lint/struct.LintStore.html#method.check_lint_name), to handle the case that a scoped `tool_lint` doesn't exist in the tool. This is currently not handled by the compiler: https://github.com/rust-lang/rust/blob/595345419d12c3ea860151df52f78744a31bafff/src/librustc/lint/levels.rs#L309-L314 Needed for rust-lang/rust-clippy#3161 r? @Manishearth

clippy_lints/src/attrs.rs

phansch · 2018-11-01T06:04:36Z

tests/ui/unknown_clippy_lints.rs

@@ -0,0 +1,8 @@
+


Should this test also the old cfg_attr attributes?

I would recommend to explicitly write a lint for cfg_attr. I actually already did: flip1995@1f9c0a9

The problem is, that it's impossible to lint crate-level cfg_attrs, which makes this lint only semi valuable.

phansch · 2018-11-01T19:42:34Z

r=me once the build is working properly again

phansch · 2018-11-02T05:55:44Z

bors r+

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 3387: Replace big if/else expression with match r=flip1995 a=mikerite 3388: RIIR update lints: Generate deprecated lints r=phansch a=phansch The update script now also generates the 'register_removed' section in `clippy_lints/src/lib.rs`. Also, instead of using `let mut store ...`, I added a new identifier line so that the replacement will continue to work in case `let mut store ...` ever changes. cc #2882 Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Michael Wright <mikerite@lavabit.com> Co-authored-by: Philipp Hansch <dev@phansch.net>

bors · 2018-11-02T06:29:28Z

Build failed (retrying...)

continuous-integration/travis-ci/push

phansch · 2018-11-02T06:31:39Z

This needs an updated stderr flie after adding the copyright notice ©️

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 3387: Replace big if/else expression with match r=flip1995 a=mikerite Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Michael Wright <mikerite@lavabit.com>

phansch · 2018-11-02T07:21:37Z

bors r- (because I think otherwise it gets included in these 'rollup' commits?)

bors · 2018-11-02T07:21:37Z

Canceled

flip1995 · 2018-11-02T13:17:45Z

bors r=phansch

3161: New lint: Unknown clippy lints r=phansch a=flip1995 This is the Clippy version of the `rustc` lint `unknown_lints`. The behavior of this lint is pretty much the same. Before this is merged a small change in the compiler needs to be done: `CheckLintNameResult` needs to be public. See rust-lang/rust#54106 Co-authored-by: flip1995 <9744647+flip1995@users.noreply.github.com> Co-authored-by: flip1995 <hello@philkrones.com>

bors · 2018-11-02T13:53:52Z

Build succeeded

flip1995 mentioned this pull request Sep 10, 2018

Reexport CheckLintNameResult rust-lang/rust#54106

Merged

oli-obk reviewed Sep 10, 2018

View reviewed changes

flip1995 closed this Sep 12, 2018

flip1995 reopened this Sep 12, 2018

phansch reviewed Sep 13, 2018

View reviewed changes

clippy_lints/src/attrs.rs Outdated Show resolved Hide resolved

flip1995 force-pushed the unknown_clippy_lints branch from ea1116f to 146ff14 Compare September 15, 2018 09:05

flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 15, 2018

flip1995 force-pushed the unknown_clippy_lints branch 2 times, most recently from 6f00e1c to 1c4221c Compare September 29, 2018 12:58

flip1995 force-pushed the unknown_clippy_lints branch 2 times, most recently from 7d45441 to 167436a Compare October 15, 2018 13:20

phansch suggested changes Nov 1, 2018

View reviewed changes

flip1995 force-pushed the unknown_clippy_lints branch from 167436a to 6f584f3 Compare November 1, 2018 19:37

phansch approved these changes Nov 1, 2018

View reviewed changes

flip1995 and others added 7 commits November 2, 2018 13:49

Add new lint: unknwon_clippy_lintsg

f6d5786

Add tests for unknwon_clippy_lints lint

8d516b3

run update_lints script

6819127

Fix typo and indentation

ea4a80f

Fix dogfood error

cf89c40

Fix typos

014cf3d

flip1995 added 2 commits November 2, 2018 13:49

Update stderr

faa1db3

Allow single_match_else

32396f6

flip1995 force-pushed the unknown_clippy_lints branch from 196addb to 32396f6 Compare November 2, 2018 13:01

bors bot merged commit 32396f6 into rust-lang:master Nov 2, 2018

flip1995 mentioned this pull request Feb 28, 2019

Cognitive Complexity (step 1 out of 3+): name changes #3803

Merged

flip1995 deleted the unknown_clippy_lints branch June 18, 2019 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New lint: Unknown clippy lints #3161

New lint: Unknown clippy lints #3161

flip1995 commented Sep 10, 2018 •

edited

Loading

oli-obk Sep 10, 2018

oli-obk Sep 10, 2018

oli-obk Sep 10, 2018

flip1995 Sep 10, 2018

oli-obk Sep 10, 2018

flip1995 Sep 29, 2018

phansch Oct 2, 2018

phansch Nov 1, 2018

phansch Nov 1, 2018

flip1995 Nov 1, 2018 •

edited

Loading

phansch commented Nov 1, 2018

phansch commented Nov 2, 2018

bors bot commented Nov 2, 2018

phansch commented Nov 2, 2018

phansch commented Nov 2, 2018

bors bot commented Nov 2, 2018

flip1995 commented Nov 2, 2018

bors bot commented Nov 2, 2018

New lint: Unknown clippy lints #3161

New lint: Unknown clippy lints #3161

Conversation

flip1995 commented Sep 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flip1995 Nov 1, 2018 • edited Loading

Choose a reason for hiding this comment

phansch commented Nov 1, 2018

phansch commented Nov 2, 2018

bors bot commented Nov 2, 2018

Build failed (retrying...)

phansch commented Nov 2, 2018

phansch commented Nov 2, 2018

bors bot commented Nov 2, 2018

Canceled

flip1995 commented Nov 2, 2018

bors bot commented Nov 2, 2018

Build succeeded

flip1995 commented Sep 10, 2018 •

edited

Loading

flip1995 Nov 1, 2018 •

edited

Loading