Implement unnecesary_filter_map lint #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
S-waiting-on-review
phansch
suggested changes
Sep 28, 2018
tests/ui/methods.rs
Outdated
| @@ -443,3 +443,17 @@ fn main() { | |||
| let opt = Some(0); | |||
| let _ = opt.unwrap(); | |||
| } | |||
|
|
|||
| /// Checks implementation of `UNNECESSARY_FILTER_MAP` lint | |||
There was a problem hiding this comment.
It would be nice to move these tests to their own tests/ui/unnecessary_filter_map.rs file so that the UI diffs are smaller. (#2038)
clippy_lints/src/methods.rs
Outdated
| @@ -1398,6 +1424,144 @@ fn lint_unnecessary_fold(cx: &LateContext<'_, '_>, expr: &hir::Expr, fold_args: | |||
| }; | |||
| } | |||
|
|
|||
| mod unnecessary_filter_map { | |||
There was a problem hiding this comment.
Do you think it's possible to move this to its own file? methods.rs is already quite large.
phansch
added
S-waiting-on-author
phansch
approved these changes
Sep 29, 2018
|
I totally broke the update_lints.py when I changed the modules. Please don't merge until I fix. |
ghost
changed the title
ghost
changed the title
|
It's done. |
|
Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.