Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIIR update_lints: Update changelog links #3327

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 17, 2018

This now also updates the link list at the bottom of the changelog.

cc #2882

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This now also updates the link list at the bottom of the changelog.
@@ -59,8 +59,8 @@ fn print_lints() {
}

fn update_lints() {
let lint_list = gather_all();
let usable_lints: Vec<Lint> = Lint::usable_lints(lint_list).collect();
let lint_list: Vec<Lint> = gather_all().collect();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now a Vec because the iterator would have been consumed the first time it's used. Now it's cloning the Vec for every replace_region_in_file. Not sure if there's a better way. At least the files are only parsed once.

@oli-obk oli-obk merged commit f40c4fa into rust-lang:master Oct 17, 2018
@phansch phansch deleted the update_changelog_riir branch October 17, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants