Teach suspicious_else_formatting about if .. {..} {..}
#3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a rustc bug: we got an |
|
Minimal(-ish) reproducer here: https://github.com/HMPerson1/rustc-macros-span-bug |
|
Reported as rust-lang/rust#55232 |
HMPerson1
force-pushed
the
possibly_missing_else
branch
from
1582a3f to
faa029f
Compare
|
@HMPerson1 sorry this took so long to review, the changes look good to me! Could you rebase one more time? |
phansch
added
the
S-waiting-on-author
HMPerson1
force-pushed
the
possibly_missing_else
branch
from
faa029f to
c9e48ac
Compare
HMPerson1
force-pushed
the
possibly_missing_else
branch
from
c9e48ac to
05ae391
Compare
|
@bors r+ thanks! |
|
📌 Commit 05ae391 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 22, 2018
Teach `suspicious_else_formatting` about `if .. {..} {..}`
We essentially treat bare blocks `{..}` identically to `if .. {..}`, except for different lint messages.
Fixes #3044
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We essentially treat bare blocks
{..}identically toif .. {..}, except for different lint messages.Fixes #3044