Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add lint for hex and binary literals that aren't grouped by bytes or nibbles #3391

Closed
wants to merge 1 commit into from
Closed

WIP: Add lint for hex and binary literals that aren't grouped by bytes or nibbles #3391

wants to merge 1 commit into from

Conversation

fhartwig
Copy link
Contributor

Still needs tests, documentation and general cleanup. An informal survey of existing rust code shows that hex literals are only ever grouped by byte, binary literals are only ever grouped by nibble and nobody seems to group octal literals at all.

Fixes #2538

I'd be happy to get suggestions for the lint name, this is mostly a placeholder because I cannot think of a good name right now.

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2018
@flip1995
Copy link
Member

UNUSUAL_DIGIT_GROUPING maybe. This would follow the naming scheme of INCONSISTENT_DIGIT_GROUPING (and LARGE_DIGIT_GROUPS)

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 19, 2018
@phansch
Copy link
Member

phansch commented Nov 30, 2018

@fhartwig It looks like there has been some feedback, would you like to continue with this (and the other) PR?

@flip1995
Copy link
Member

Ping from triage @fhartwig: It looks like this PR hasn't received any updates in a while, so I'm closing it per our new guidelines. Thank you for your contributions and please feel free to re-open in the future.

@flip1995 flip1995 closed this Dec 14, 2018
@flip1995 flip1995 added S-inactive-closed Status: Closed due to inactivity and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 14, 2018
@cgm616
Copy link
Contributor

cgm616 commented Oct 16, 2020

I'd like to pick this one up and revive it.

@cgm616 cgm616 mentioned this pull request Oct 16, 2020
Merged
bors added a commit that referenced this pull request Oct 25, 2020
@bors
Auto merge of #6183 - cgm616:hex_bin_digit_grouping, r=flip1995
eceebc3 
Hex bin digit grouping

This revives and updates an old pr (#3391) for the current API.

Closes #2538.

---

*Please keep the line below*
changelog: Add [`unusual_byte_groupings`] lint.
@HKalbasi
Copy link
Member

finished in #6183
@rustbot label -S-inactive-closed

@rustbot rustbot removed the S-inactive-closed Status: Closed due to inactivity label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underscores only every 2^n digits in non-decimal numbers
6 participants
@fhartwig @flip1995 @phansch @cgm616 @HKalbasi @rustbot