Skip to content

RIIR update lints: Generate modules section and lint group sections #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2018
Merged

RIIR update lints: Generate modules section and lint group sections #3399

merged 5 commits into from
Nov 3, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Nov 2, 2018 •
edited
Loading

This adds the last missing parts of the generating code.

cc #2882

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2018
@phansch phansch force-pushed the riir_update_lints_gen_modules branch from 4a68030 to 1e6b33e Compare November 2, 2018 07:19
phansch
phansch commented Nov 2, 2018
View reviewed changes
@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 2, 2018
@phansch phansch force-pushed the riir_update_lints_gen_modules branch from 1e6b33e to 5fc25d3 Compare November 3, 2018 08:09
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 3, 2018
@phansch phansch changed the title RIIR update lints: Generate modules section RIIR update lints: Generate modules section and lint group sections Nov 3, 2018
@phansch
Copy link
Member Author

phansch commented Nov 3, 2018

This now also includes the generation of the register_lint_group section.

@phansch phansch force-pushed the riir_update_lints_gen_modules branch from 3f07c63 to cca5070 Compare November 3, 2018 12:43
flip1995
flip1995 reviewed Nov 3, 2018
View reviewed changes
clippy_dev/src/main.rs Outdated
.about("Makes sure that:\n \
* the lint count in README.md is correct\n \
* the changelog contains markdown link references at the bottom\n \
* all lints groups include the correct lints\n \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT:

Suggested change
* all lints groups include the correct lints\n \
* all lint groups include the correct lints\n \

r=me with that change

@phansch
Copy link
Member Author

phansch commented Nov 3, 2018

bors r=flip1995

bors bot added a commit that referenced this pull request Nov 3, 2018
@bors @phansch
Merge #3399
a07c271 
3399: RIIR update lints: Generate modules section and lint group sections r=flip1995 a=phansch

This adds the last missing parts of the generating code.

cc #2882

Co-authored-by: Philipp Hansch <dev@phansch.net>
@bors
Copy link
Contributor

bors bot commented Nov 3, 2018

Build succeeded

@bors bors bot merged commit facfb5a into rust-lang:master Nov 3, 2018
@phansch phansch deleted the riir_update_lints_gen_modules branch November 3, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phansch @flip1995