Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() ) #3512

Merged
merged 4 commits into from
Dec 8, 2018

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 8, 2018

Closes #3506

@oli-obk
Copy link
Contributor

oli-obk commented Dec 8, 2018

Travis is unhappy. I'm on mobile and it won't load for me right now

@phansch
Copy link
Member

phansch commented Dec 8, 2018

The previous error: casting from *const u8 to a more-strictly-aligned pointer (*const u16) error still seems to be there.

matthiaskrgr and others added 2 commits December 8, 2018 12:05
The path of `libc::c_void` has changes in rust-lang/libc@5c1a6b8
The DefId path is now always platform specific like
`libc::windows::c_void`. This fixes our c_void detection to only check
the first and last elements.
@phansch
Copy link
Member

phansch commented Dec 8, 2018

Rebased and fixed the c_void issue. There's still some pedantic lints triggering which I will fix now.

@matthiaskrgr
Copy link
Member Author

Ah sorry, looks like I wrongly linked the issue.

@phansch phansch merged commit a3c77f6 into rust-lang:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants