rustfmt tests #3529
Merged
rustfmt tests #3529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkuu
reviewed
Dec 11, 2018
phansch
added
the
S-waiting-on-author
…nd add #[rustfmt::skip]
phansch
approved these changes
Dec 11, 2018
matthiaskrgr
added
S-waiting-on-review
Contributor
|
appveyor is unhappy |
Contributor
|
@oli-obk yup, that's probably going to be fixed by rust-lang-deprecated/failure#279 |
Member
Author
|
@bors try |
Contributor
bors
added a commit
that referenced
this pull request
Dec 11, 2018
rustfmt tests also fails CI if tests turn out to not be formatted properly.
Member
Author
|
./ci/base-tests.sh: line 44: [: missing |
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 36266b3 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Dec 12, 2018
rustfmt tests also fails CI if tests turn out to not be formatted properly.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 12, 2018
This was referenced Dec 12, 2018
Merged
Member
Author
|
The fact that CI was green while there was a syntax error in the script is actually quite concerning... |
Member
|
I'd didn't exit because it was told not to exit on error Line 35 in 921d4da |
bors
added a commit
that referenced
this pull request
Dec 12, 2018
base-tests: don't print all commands to stdout during the loop Fixes thinko in #3529
Member
Author
|
Fixed via #3537 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fails CI if tests turn out to not be formatted properly.