Implements lint for order comparisons against bool (#3438) #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Dec 17, 2018
tests/ui/bool_comparison.stderr
Outdated
| --> $DIR/bool_comparison.rs:74:8 | ||
| | | ||
| 74 | if x < y { | ||
| | ^^^^^ help: try simplifying it as shown: `!x && y` |
There was a problem hiding this comment.
The suggestion is not identical if x or y have side effects. I think we should use & here so that both sides are evaluated. We can leave it to the user to use && or add a performance lint about changing & to && in the future
There was a problem hiding this comment.
The lint about & vs && is practically finished: #3385, just needs tests and doc
There was a problem hiding this comment.
Seems great, just uploaded new changes
|
@bors r+ |
|
📌 Commit de42dfb has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on issue #3438, this change implements linting for
>and<comparisons against bothbooleanliterals and between expressions.