base tests: switch to nightly toolchain before checking formatting of tests with rustfmt #3586
Conversation
matthiaskrgr
changed the title
|
the nightly toolchain is also not guaranteed to have rustfmt available, right? We could just run stable's rustfmt |
|
Most people who hack on clippy probably use the nightly toolchain so it makes sense to use nightly rustfmt I think. Also rustfmt breaks fare less often now that it uses rustc_ap* crates, I don't think it is that problematic to use nightly rustfmt. |
|
@bors r+ |
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [WIP] from this PR's title when it is ready for review. |
|
@bors r- |
matthiaskrgr
force-pushed
the
test_fmt_fix
branch
from
cf97299 to
d021ed5
Compare
|
Grr, ci is supposed to fail on this now, so it's still not working correctly... |
matthiaskrgr
force-pushed
the
test_fmt_fix
branch
4 times, most recently
from
a4f73a8 to
df87dce
Compare
|
Ok, it's finally failing successfully now :D 🎉 |
matthiaskrgr
changed the title
matthiaskrgr
force-pushed
the
test_fmt_fix
branch
from
b56c26c to
3e07a88
Compare
… tests with rustfmt this errored because rustfmt is not available on the master toolchain
fix script one last time™
matthiaskrgr
force-pushed
the
test_fmt_fix
branch
from
3e07a88 to
38fabcb
Compare
|
I swear, I will only need 10 more tries until this finally works... |
|
Finally.. |
|
📌 Commit 38fabcb has been approved by |
base tests: switch to nightly toolchain before checking formatting of tests with rustfmt this errored because rustfmt is not available on the master toolchain
|
💥 Test timed out |
|
@bors retry |
base tests: switch to nightly toolchain before checking formatting of tests with rustfmt this errored because rustfmt is not available on the master toolchain
|
☀️ Test successful - status-appveyor, status-travis |
this errored because rustfmt is not available on the master toolchain