Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup (don't know the exact PR unfortunately) #3633

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@phansch
Copy link
Member

phansch commented Jan 5, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 5, 2019

📌 Commit 33ec4e5 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 5, 2019

⌛ Testing commit 33ec4e5 with merge 88f8fca...

bors added a commit that referenced this pull request Jan 5, 2019
rustup (don't know the exact PR unfortunately)
@bors
Copy link
Contributor

bors commented Jan 5, 2019

💔 Test failed - status-appveyor

@phansch
Copy link
Member

phansch commented Jan 5, 2019

It looks like there's a new error:

   Compiling clippy_lints v0.0.212 (C:\projects\rust-clippy\clippy_lints)
error[E0599]: no method named `def_id` found for type `std::option::Option<rustc::ty::Binder<rustc::ty::ExistentialTraitRef<'_>>>` in the current scope
   --> clippy_lints\src\len_zero.rs:307:46
    |
307 |             .associated_items(tt.principal().def_id())
    |                                              ^^^^^^

Looks like tt.principal() returns an Option now?

(I wont have time to r+ until Monday)

@matthiaskrgr
Copy link
Member Author

Looks like that changed after I made the pr...
Anyway, updated.

@matthiaskrgr
Copy link
Member Author

@bors r=phansch

@bors
Copy link
Contributor

bors commented Jan 5, 2019

📌 Commit a4b99c6 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 5, 2019

⌛ Testing commit a4b99c6 with merge 488b8c5...

bors added a commit that referenced this pull request Jan 5, 2019
rustup (don't know the exact PR unfortunately)
@bors
Copy link
Contributor

bors commented Jan 5, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing 488b8c5 to master...

@bors bors merged commit a4b99c6 into rust-lang:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants