Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE in decimal_literal_representation lint #3931

Merged
merged 4 commits into from
Apr 10, 2019
Merged

Fix ICE in decimal_literal_representation lint #3931

merged 4 commits into from
Apr 10, 2019

Commits on Apr 8, 2019

  1. Fix ICE in decimal_literal_representation lint 

    Handling the integer parsing properly instead of just unwrapping.

Note that the test is not catching the ICE because plain UI tests
[currently hide ICEs][compiletest_issue]. Once that issue is fixed, this
test would fail properly again.

[compiletest_issue]: Manishearth/compiletest-rs#169
    @phansch
    phansch committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    0307ff0 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Exclude ice-3891.rs from rustfmt run 

    Because the code triggers a rustc parse error which makes rustfmt fail.
    @phansch
    phansch committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    0eb7596 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. Code formatting/cleanup

    @phansch
    phansch committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    1fd2451 View commit details
    Browse the repository at this point in the history

  2. Refactor check_lit method

    @phansch
    phansch committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    ab6b949 View commit details
    Browse the repository at this point in the history