Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest .copied() instead of .cloned() in map_clone where applicable #3970

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 15, 2019

partial fix for #3958

changelog: Improve suggestion in map_clone to suggest .copied() where applicable

@Manishearth
Copy link
Member Author

Once .copied() stabilizes we can also extend clone_on_copy to deal with this.

(we may want to do this for Option too)

@Manishearth
Copy link
Member Author

We could for now land this just for Option

@Manishearth Manishearth changed the title [DO NOT MERGE] Suggest .copied() instead of .cloned() in map_clone where applicable Suggest .copied() instead of .cloned() in map_clone where applicable Apr 15, 2019
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2019

📌 Commit e9cde41 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Apr 16, 2019

⌛ Testing commit e9cde41 with merge 3e8d992...

bors added a commit that referenced this pull request Apr 16, 2019
Suggest .copied() instead of .cloned() in map_clone where applicable

partial fix for #3958

changelog: Improve suggestion in `map_clone` to suggest `.copied()` where applicable
@bors
Copy link
Collaborator

bors commented Apr 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 3e8d992 to master...

@bors bors merged commit e9cde41 into master Apr 16, 2019
@flip1995 flip1995 deleted the map_copied branch April 16, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants