Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "if types change" to "if you later change the type" #4021

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

kraai
Copy link
Contributor

@kraai kraai commented Apr 24, 2019

Fixes #3964.

changelog: change wording of cast_lossless message

@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Apr 24, 2019

📌 Commit 9a43e09 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 24, 2019

⌛ Testing commit 9a43e09 with merge 92d703f...

bors added a commit that referenced this pull request Apr 24, 2019
Change "if types change" to "if you later change the type"

Fixes #3964.

changelog: change wording of `cast_lossless` message
@bors
Copy link
Contributor

bors commented Apr 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 92d703f to master...

@bors bors merged commit 9a43e09 into rust-lang:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"casting u32 to f64 may become silently lossy if types change" doesn't make sense
3 participants