Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivially_copy_pass_by_ref: print size of type and limit in the lint message #4071

Merged
merged 1 commit into from
May 28, 2019
Merged

trivially_copy_pass_by_ref: print size of type and limit in the lint message #4071

merged 1 commit into from
May 28, 2019

Conversation

matthiaskrgr
Copy link
Member

changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message

@matthiaskrgr
Copy link
Member Author

Note: this is still work in progress, I'll have to make the sure the test passes on different platforms, but wanted some earlier feedback on the general idea.

Perhaps this will help: https://rust-lang.github.io/rustc-guide/tests/adding.html#normalization

@oli-obk
Copy link
Contributor

oli-obk commented May 8, 2019

I like the idea, but I think the diagnostic should be more verbose in explaining the sizes. Basically I think there should be no need to go to the documentation to understand the lint the first time one sees it.

@matthiaskrgr matthiaskrgr changed the title [WIP] trivially_copy_pass_by_ref: print size of type and limit in the lint message trivially_copy_pass_by_ref: print size of type and limit in the lint message May 8, 2019
@matthiaskrgr matthiaskrgr marked this pull request as ready for review May 8, 2019 22:48
@matthiaskrgr
Copy link
Member Author

I updated the test to use normalized output!

@matthiaskrgr
Copy link
Member Author

Hm, looks like [ui] ui-toml/toml_trivially_copy/test.rs is failing
https://travis-ci.com/rust-lang/rust-clippy/jobs/198724409#L904

@matthiaskrgr matthiaskrgr added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 9, 2019
@matthiaskrgr
Copy link
Member Author

bump?

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 28, 2019

📌 Commit 5d58163 has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 28, 2019

⌛ Testing commit 5d58163 with merge d57845f...

bors added a commit that referenced this pull request May 28, 2019
@bors
Auto merge of #4071 - matthiaskrgr:sizeof, r=flip1995
d57845f 
trivially_copy_pass_by_ref: print size of type and limit in the lint message

changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message
@bors
Copy link
Contributor

bors commented May 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing d57845f to master...

@bors bors merged commit 5d58163 into rust-lang:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @oli-obk @flip1995 @bors @phansch