Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #4101 to beta #4104

Merged
merged 3 commits into from
May 17, 2019
Merged

Backport #4101 to beta #4104

merged 3 commits into from
May 17, 2019

Conversation

Manishearth
Copy link
Member

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

@Manishearth Manishearth force-pushed the beta-backports branch 4 times, most recently from 65a3eb4 to 81cf55d Compare May 17, 2019 00:59
@Manishearth
Copy link
Member Author

r? @oli-obk @phansch

(if r+, just merge directly. I'll deal with upstream backporting later)

@flip1995
Copy link
Member

The test files are broken. This was fixed in 08d2a0d. Should we fix this here or just ignore it (it doesn't really matter for the backport)?

@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 059019a has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
cb1ea7e 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 059019a with merge cb1ea7e...

@bors
Copy link
Contributor

bors commented May 17, 2019

💔 Test failed - status-appveyor

@flip1995
Copy link
Member

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 426faff has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
6b32f65 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 426faff with merge 6b32f65...

@flip1995
Copy link
Member

Squashed the commits, for less noice on the backport branch.

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 19adb57 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 19adb57 with merge fe4cbe1...

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
fe4cbe1 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 17, 2019

💔 Test failed - status-appveyor

phansch
phansch reviewed May 17, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@Manishearth @oli-obk
Backport rust-lang#4101
9170ca3 
rust-lang#4101

Splits up redundant_closure's method checking into a pedantic lint
@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 9170ca3 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 9170ca3 with merge 1f55631...

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
1f55631 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 17, 2019

💔 Test failed - status-appveyor

@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 64a9f56 has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
825ac3a 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 64a9f56 with merge 825ac3a...

@bors
Copy link
Contributor

bors commented May 17, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

flip1995 commented May 17, 2019 •
edited
Loading

"All checks have passed" 🎉 Now it's bors' turn

@bors r+

@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
8434618 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 28bde06 has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Testing commit 28bde06 with merge 265318d...

bors added a commit that referenced this pull request May 17, 2019
@bors
Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
265318d 
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@phansch phansch mentioned this pull request May 17, 2019
Closed
@bors
Copy link
Contributor

bors commented May 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 265318d to beta1.35...

@bors bors merged commit 28bde06 into rust-lang:beta1.35 May 17, 2019
@Manishearth
Copy link
Member Author

Yeah it's fine it the tests are kinda broken.

I'll put up a beta backport PR today

@Manishearth Manishearth deleted the beta-backports branch May 17, 2019 17:15
@Manishearth Manishearth mentioned this pull request May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @flip1995 @oli-obk @bors @phansch