-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent symbocalypse #4110
Merged
Merged
Prevent symbocalypse #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bors r+ |
📌 Commit f7f85a0 has been approved by |
bors
added a commit
that referenced
this pull request
May 17, 2019
Prevent symbocalypse r? @Manishearth This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us changelog: none
💔 Test failed - status-appveyor |
@bors r- gonna turn off those serde tests for now |
@bors r=Manishearth |
📌 Commit 462df72 has been approved by |
bors
added a commit
that referenced
this pull request
May 17, 2019
Prevent symbocalypse r? @Manishearth This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us changelog: none
💔 Test failed - status-appveyor |
@bors r+ |
📌 Commit f49ef0e has been approved by |
bors
added a commit
that referenced
this pull request
May 17, 2019
Prevent symbocalypse r? @Manishearth This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us changelog: none
☀️ Test successful - checks-travis, status-appveyor |
This was referenced May 18, 2019
Closed
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 18, 2019
Update clippy Contains rust-lang/rust-clippy#4110 Should fix RLS r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
This is strictly better, we can just not modify rustc and bump solely the clippy submodule and then implement diagnostic lang items without beta looming over us
changelog: none