Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup https://github.com/rust-lang/rust/pull/60928 #4153

Merged
merged 1 commit into from
May 29, 2019
Merged

rustup https://github.com/rust-lang/rust/pull/60928 #4153

merged 1 commit into from
May 29, 2019

Conversation

matthiaskrgr
Copy link
Member

changelog: none

@matthiaskrgr
Copy link
Member Author

I did this speculatively, the change upstream change did not merge yet and I have not tested if this actually builds.

@flip1995
Copy link
Member

It's merged now

@flip1995 flip1995 closed this May 29, 2019
@flip1995 flip1995 reopened this May 29, 2019
@matthiaskrgr
Copy link
Member Author

All tests pass locally with rustc master now.
r? @flip1995

@flip1995
Copy link
Member

also in travis 👍

@bors r+

@bors
Copy link
Contributor

bors commented May 29, 2019

📌 Commit 22e77df has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge f721683...

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
f721683 
rustup rust-lang/rust#60928

changelog: none
@matthiaskrgr matthiaskrgr mentioned this pull request May 29, 2019
Merged
@bors
Copy link
Contributor

bors commented May 29, 2019

💔 Test failed - status-appveyor

@matthiaskrgr
Copy link
Member Author

Can't really see what's wrong. Perhaps dogfood froze?
@bors retry

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge 9586d73...

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
9586d73 
rustup rust-lang/rust#60928

changelog: none
@matthiaskrgr
Copy link
Member Author

It's hanging again, this time on travis...
@bors retry

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
6361040 
rustup rust-lang/rust#60928

changelog: none
@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge 6361040...

@bors
Copy link
Contributor

bors commented May 29, 2019

💔 Test failed - checks-travis

@oli-obk
Copy link
Contributor

oli-obk commented May 29, 2019

@bors retry mac network error

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge fd6161a...

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
fd6161a 
rustup rust-lang/rust#60928

changelog: none
@bors
Copy link
Contributor

bors commented May 29, 2019

💥 Test timed out

@flip1995
Copy link
Member

@bors retry (appveyor again)

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge 04e5f7e...

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
04e5f7e 
rustup rust-lang/rust#60928

changelog: none
@bors
Copy link
Contributor

bors commented May 29, 2019

💥 Test timed out

@oli-obk
Copy link
Contributor

oli-obk commented May 29, 2019

@bors retry

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
a49511c 
rustup rust-lang/rust#60928

changelog: none
@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge a49511c...

@bors
Copy link
Contributor

bors commented May 29, 2019

💥 Test timed out

@phansch
Copy link
Member

phansch commented May 29, 2019

The AppVeyor build seems to have started one hour after it was queued; that's definitely too late :/

@matthiaskrgr
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented May 29, 2019

⌛ Testing commit 22e77df with merge 018fa30...

bors added a commit that referenced this pull request May 29, 2019
@bors
Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995
018fa30 
rustup rust-lang/rust#60928

changelog: none
@bors
Copy link
Contributor

bors commented May 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 018fa30 to master...

@bors bors merged commit 22e77df into rust-lang:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @flip1995 @bors @oli-obk @phansch