Fixing eta with respect to lazy evaluation. #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projedi
changed the title
|
Oops. I did not see you were working on this and did (mostly) the same thing. |
Oh, I didn't notice that you did it too. Well, I don't mind whose PR gets merged in, as long as the problem is fixed. I can close this one, if you like. |
|
Travis failure looks like a bug in -fn make_lazy(f: fn() -> fn(u8) -> u8) -> impl Fn(u8) -> u8 {
+fn make_lazy(f: fn() -> fn(u8) -> fn(u8) -> u8) -> impl Fn(u8) -> u8 { |
I think you're right, opened rust-lang/rustfmt#3615 to track it. There's a workaround, though: changing type of |
|
Thanks! @bors r+ |
|
📌 Commit 41a4ce5 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 10, 2019
Fixing eta with respect to lazy evaluation. This fixes #4187 changelog: `redundant_closure`: stop linting on expressions returning a function, which is then directly used by the closure
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4187
changelog:
redundant_closure: stop linting on expressions returning a function, which is then directly used by the closure