fix suggestion for floating point inequality #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be of the form `(a - b).abs() > error` whereas it was `(a - b).abs() < error` that is instead what should be used for equality.
flip1995
approved these changes
Jun 17, 2019
|
@bors r+ |
|
📌 Commit be14ea8 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 17, 2019
fix suggestion for floating point inequality It should be of the form `(a - b).abs() > error` whereas it was `(a - b).abs() < error` that is instead what should be used for equality. fixes #4204. changelog: fix suggestion for floating point inequality
|
☀️ Test successful - checks-travis, status-appveyor |
|
thanks for merging the PR so quickly! 🎉 |
|
Thanks for fixing this issue so quickly! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be of the form
(a - b).abs() > errorwhereas it was(a - b).abs() < errorthat is instead what should be used for equality.fixes #4204.
changelog: fix suggestion for floating point inequality