Avoid reporting string_lit_as_bytes for long strings #4233
Merged
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
Ah, thank you. And I'm terribly sorry for not continuing the work. :( |
|
No problem! Thanks for the initial work. This is mostly your code. I've just ported it. |
phansch
reviewed
Jul 8, 2019
clippy_lints/src/strings.rs
Outdated
| @@ -173,6 +173,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for StringLitAsBytes { | |||
| ); | |||
| } else if callsite == expanded | |||
| && lit_content.as_str().chars().all(|c| c.is_ascii()) | |||
| && lit_content.as_str().len() <= 32 | |||
There was a problem hiding this comment.
It would be nice to extract the number into a const and add a small comment to it.
There was a problem hiding this comment.
How about 7d1a944?
Port of @jens1o code ([b76f939][jens1o_commit]) Fixes rust-lang#1208 [jens1o_commit]: jens1o@b76f939 Co-authored-by: Thiago Arrais <thiago.arrais@gmail.com>
thiagoarrais
force-pushed
the
jens1o-fix-1208
branch
from
445f7e1
to
7d1a944
Compare
flip1995
approved these changes
Jul 9, 2019
|
@bors r=phansch,flip1995 thanks! |
|
📌 Commit 7d1a944 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 9, 2019
Avoid reporting string_lit_as_bytes for long strings Port of @jens1o code ([b76f939][jens1o_commit]) Fixes #1208 [jens1o_commit]: jens1o@b76f939 <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `util/dev update_lints` - [ ] Added lint documentation - [ ] Run `cargo fmt` Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> changelog: bugfix for long strings as bytes
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of @jens1o code (b76f939)
Fixes #1208
changelog: bugfix for long strings as bytes