Move {unnecessary,panicking}_unwrap out of nursery #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
cc @oli-obk You suggested to have these lints in nursery back then. Do you still have any concerns why these lints shouldn't be in |
|
No @bors r+ |
|
📌 Commit 87a2874 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 31, 2019
Move {unnecessary,panicking}_unwrap out of nursery
Resolves #2437
changelog: Move `{unnnecessary,panicking}_unwrap` out of nursery
|
@bors r- why do doctests only fail for non-nursery lints? |
|
💔 Test failed - checks-travis |
This shouldn't happen with NLL
flip1995
force-pushed
the
unnecessary_unwrap
branch
from
87a2874
to
feca48d
Compare
|
@bors r=oli-obk |
|
📌 Commit feca48d has been approved by |
bors
added a commit
that referenced
this pull request
Aug 1, 2019
Move {unnecessary,panicking}_unwrap out of nursery
Resolves #2437
changelog: Move `{unnnecessary,panicking}_unwrap` out of nursery
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2437
changelog: Move
{unnnecessary,panicking}_unwrapout of nursery