Fix missing_const_for_fn false positive #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
added
the
S-waiting-on-review
flip1995
requested changes
Aug 26, 2019
flip1995
added
S-waiting-on-author
We don't want to lint if any of the input parameters implement drop. (constant functions cannot evaluate destructors)
phansch
force-pushed
the
fix_const_fn_fp
branch
from
8d4dd77 to
1b18597
Compare
|
The lint now checks all arguments for types that implement |
phansch
added
S-waiting-on-review
|
Apparently I forgot to commit the updated .stderr, will do that later today 🤦♂️ |
|
@bors r=flip1995 |
|
📌 Commit 5e1fdf9 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 29, 2019
Fix missing_const_for_fn false positive We don't want to lint if the type of the method implements drop. (constant functions cannot evaluate destructors) changelog: Fix `missing_const_for_fn` false positive Fixes #4449
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to lint if the type of the method implements drop.
(constant functions cannot evaluate destructors)
changelog: Fix
missing_const_for_fnfalse positiveFixes #4449