Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 2 pull requests #4463

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Rollup of 2 pull requests #4463

merged 4 commits into from
Aug 28, 2019

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 28, 2019

Successful merges:

Failed merges:

r? @ghost

changelog: none

JohnTitor and others added 4 commits August 28, 2019 03:17
…ip1995

Add note to avoid confusing

Fixes rust-lang#4456

changelog: none
…flip1995

Fix `inherent_to_string` false positive

Fixes rust-lang#4457

changelog: fixes `inherent_to_string` false positive
@flip1995
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 28, 2019

📌 Commit 2366661 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 28, 2019

⌛ Testing commit 2366661 with merge ba8cdfe...

bors added a commit that referenced this pull request Aug 28, 2019
Rollup of 2 pull requests

Successful merges:

 - #4459 (Add note to avoid confusing)
 - #4460 (Fix `inherent_to_string` false positive)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Aug 28, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member Author

Everytime when I create a rollup, I forget the changelog...

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 28, 2019

⌛ Testing commit 2366661 with merge a939d61...

bors added a commit that referenced this pull request Aug 28, 2019
Rollup of 2 pull requests

Successful merges:

 - #4459 (Add note to avoid confusing)
 - #4460 (Fix `inherent_to_string` false positive)

Failed merges:

r? @ghost

changelog: none
@bors
Copy link
Collaborator

bors commented Aug 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a939d61 to master...

@bors bors merged commit 2366661 into rust-lang:master Aug 28, 2019
@flip1995 flip1995 deleted the rollup-240kr2c branch August 28, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants