Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check across macro boundary in deref_addrof #4487

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Sep 2, 2019

Fixes #4289

changelog: Allow deref_addrof in macros

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2019
@flip1995
Copy link
Member

flip1995 commented Sep 4, 2019

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2019

📌 Commit 9a5b996 has been approved by flip1995

bors added a commit that referenced this pull request Sep 4, 2019
Don't check across macro boundary in `deref_addrof`

Fixes #4289

changelog: Allow `deref_addrof` in macros
@bors
Copy link
Contributor

bors commented Sep 4, 2019

⌛ Testing commit 9a5b996 with merge 98a2524...

@bors
Copy link
Contributor

bors commented Sep 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 98a2524 to master...

@bors bors merged commit 9a5b996 into rust-lang:master Sep 4, 2019
@JohnTitor JohnTitor deleted the deref-addrof-external-macro branch September 4, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deref_addrof checks across external macro boundary
3 participants