Fix too_many_lines false positive
#4490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When fixing the violations, I just added an allow if I couldn't think of a sensible way of splitting the function. |
|
Allowing this lint on functions, that are just big match statements, is fine IMO. (One could find similar bodies and extract them to functions, but that makes the code not always more readable) The Thanks! @bors r+ |
|
📌 Commit 232dd43 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 4, 2019
Fix `too_many_lines` false positive changelog: Fix `too_many_lines` false positive
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix
too_many_linesfalse positive