-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE in use_self
lint
#4671
Merged
Merged
Fix ICE in use_self
lint
#4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
changed the title
Add regression test for ICE in use-self lint
WIP: Add regression test for ICE in use-self lint
Oct 15, 2019
flip1995
changed the title
WIP: Add regression test for ICE in use-self lint
WIP: Fix ICE in Oct 15, 2019
use_self
lint
futures-rs, hyper, rls
flip1995
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Oct 15, 2019
@bors try |
bors
added a commit
that referenced
this pull request
Oct 15, 2019
Fix ICE in `use_self` lint The ICE is produced by building this span: https://github.com/rust-lang/rust-clippy/blob/55e7818a06c8d83bead9c81e10e73ba33fb20890/clippy_lints/src/use_self.rs#L55-L60 `span` can start in the file the macro is defined in and end where the macro is called. changelog: Fix ICE in `use_self` lint
Let's see, if we can enable the currently disabled integration tests (2f10807) |
☀️ Try build successful - checks-travis, status-appveyor |
@bors r+ |
📌 Commit 2f10807 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 15, 2019
Fix ICE in `use_self` lint The ICE is produced by building this span: https://github.com/rust-lang/rust-clippy/blob/55e7818a06c8d83bead9c81e10e73ba33fb20890/clippy_lints/src/use_self.rs#L55-L60 `span` can start in the file the macro is defined in and end where the macro is called. changelog: Fix ICE in `use_self` lint
☀️ Test successful - checks-travis, status-appveyor |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICE is produced by building this span:
rust-clippy/clippy_lints/src/use_self.rs
Lines 55 to 60 in 55e7818
span
can start in the file the macro is defined in and end where the macro is called.changelog: Fix ICE in
use_self
lint