Do not early exit if cargo clippy returns non-zero status code #4720

tesuji · 2019-10-23T19:14:42Z

changelog: none

bors · 2019-10-24T05:56:20Z

☔ The latest upstream changes (presumably #4675) made this pull request unmergeable. Please resolve the merge conflicts.

ci/integration-tests.sh

tesuji · 2019-10-26T03:23:28Z

Run result is here: https://travis-ci.com/rust-lang/rust-clippy/builds/133650079
All virtual workspace crates now run thanks to rust-lang/rust#65710

ci/integration-tests.sh

flip1995 · 2019-10-26T18:07:38Z

Let's do a complete try run, to see on which crates this actually fails

@bors try

bors · 2019-10-26T18:07:46Z

⌛ Trying commit b8c8b3d with merge 18ad60c...

Do not early exit if cargo clippy returns non-zero status code changelog: none

tesuji · 2019-10-26T18:25:52Z

@bors clean

bors · 2019-10-26T18:25:53Z

@lzutao: 🔑 Insufficient privileges: not in try users

flip1995 · 2019-10-26T18:29:52Z

@bors delegate+

Now you can run try builds yourself :)

bors · 2019-10-26T18:29:54Z

✌️ @lzutao can now approve this pull request

tesuji · 2019-10-26T18:32:40Z

Thanks. I just wanted to stop the old try.
I think we just want to check for ICE and not check for build failure of integration tests.

tesuji · 2019-10-26T18:56:27Z

In the end, we still have no way to detect issues like #4719 from happening.

tesuji · 2019-10-26T18:57:47Z

Ready for reviewing again.

phansch · 2019-10-27T06:54:32Z

I think we just want to check for ICE and not check for build failure of integration tests.

Yup, the original idea of these tests was to detect ICEs in Clippy only.

@bors r+

bors · 2019-10-27T06:54:33Z

📌 Commit 07119d3 has been approved by phansch

bors · 2019-10-27T06:54:40Z

⌛ Testing commit 07119d3 with merge ae944a2...

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors · 2019-10-27T07:18:54Z

💔 Test failed - checks-travis

phansch · 2019-10-27T07:33:17Z

Huh, strip on macosx seems to print a lot of output and causes the build to terminate: https://api.travis-ci.com/v3/job/249890830/log.txt

tesuji · 2019-10-27T10:27:01Z

Build succeeded. @bors r=phansch

bors · 2019-10-27T10:27:03Z

📌 Commit a9f221a has been approved by phansch

bors · 2019-10-27T10:27:10Z

⌛ Testing commit a9f221a with merge 24a3199...

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors · 2019-10-27T10:27:27Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

bors · 2019-10-27T10:27:28Z

📌 Commit a9f221a has been approved by phansch

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors · 2019-10-27T10:27:35Z

⌛ Testing commit a9f221a with merge bcd8f32...

tesuji · 2019-10-27T10:27:55Z

@bors stop

tesuji · 2019-10-27T10:28:19Z

@bors force

bors · 2019-10-27T10:54:11Z

💔 Test failed - checks-travis

tesuji · 2019-10-27T11:00:11Z

Hmm, panics https://travis-ci.com/rust-lang/rust-clippy/jobs/249905118#L3505

thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: DistinctSources(DistinctSources { begin: (Real("src/lib.rs") BytePos(0)), end: (Real("src/comment.rs"), BytePos(107716)) })', src/libcore/result.rs:1165:5

stack backtrace:

   0:     0x7f0646116054 - backtrace::backtrace::libunwind::trace::h6ab2c103cc6fc063
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.37/src/backtrace/lbunwind.rs:88
   1:     0x7f0646116054 - backtrace::backtrace::trace_unsynchronized::h95032b5e76a90e2c
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.37/src/backtrace/md.rs:66
   2:     0x7f0646116054 - std::sys_common::backtrace::_print_fmt::ha3b1ff83ecbcdb5f
                               at src/libstd/sys_common/backtrace.rs:77
   3:     0x7f0646116054 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h2733e51e8a6d9b9d
                               at src/libstd/sys_common/backtrace.rs:61
   4:     0x7f064614e5cc - core::fmt::write::hc6f7822f638db26f
                               at src/libcore/fmt/mod.rs:1028
   5:     0x7f064610a437 - std::io::Write::write_fmt::ha156ae6cd02f2c84
                               at src/libstd/io/mod.rs:1412
   6:     0x7f064611a87e - std::sys_common::backtrace::_print::h20221e5a6edf398a
                               at src/libstd/sys_common/backtrace.rs:65
   7:     0x7f064611a87e - std::sys_common::backtrace::print::h982ab87d128d0fd1
                               at src/libstd/sys_common/backtrace.rs:50
   8:     0x7f064611a87e - std::panicking::default_hook::{{closure}}::h61cbb21beda1eee3
                               at src/libstd/panicking.rs:188
   9:     0x7f064611a581 - std::panicking::default_hook::hef981bb6b2fb7e35
                               at src/libstd/panicking.rs:205
  10:     0x7f06465fc133 - rustc_driver::report_ice::h3989a038ce29854d

  11:     0x7f064611b05c - std::panicking::rust_panic_with_hook::hc0f75c1814688ac8
                               at src/libstd/panicking.rs:472
  12:     0x7f064611ab12 - std::panicking::continue_panic_fmt::h4c19cc8a9675594c
                               at src/libstd/panicking.rs:375
  13:     0x7f064611aa06 - rust_begin_unwind
                               at src/libstd/panicking.rs:302
  14:     0x7f064614813a - core::panicking::panic_fmt::h88248d86527ee347
                               at src/libcore/panicking.rs:84
  15:     0x7f0646148377 - core::result::unwrap_failed::h239fa4b3235cb4bf
                               at src/libcore/result.rs:1165
  16:     0x7f06484b7a14 - rustc_errors::emitter::is_case_difference::hc0c96e664bd96574
  17:     0x7f06484ac603 - rustc_errors::emitter::Emitter::primary_span_formatted::h713cfeb3d89d48f0
  18:     0x7f06484ad95b - <rustc_errors::emitter::EmitterWriter as rustc_errors::emitter::Emitter>::emit_diagnostic::h2923ecfd46d99bd9
  19:     0x7f0648330067 - <syntax::json::JsonEmitter as rustc_errors::emitter::Emitter>::emit_diagnostic::h66a9a356fa8770ec
  20:     0x7f06484c41f9 - rustc_errors::HandlerInner::emit_diagnostic::h1eb07d02315b40bd
  21:     0x7f06484922bb - rustc_errors::diagnostic_builder::DiagnosticBuilder::emit::h3792b30815230d9f
  22:     0x5644c01296ff - <clippy_lints::utils::diagnostics::DiagnosticWrapper as core::ops::drop::Drop>::drop::h60e1e4be5ea8cce3
                               at clippy_lints/src/utils/diagnostics.rs:15
  23:     0x5644c00b2a25 - core::ptr::real_drop_in_place::h54a1e5334ec52196
                               at /rustc/cf148a717a275741a35b5f51eab182aa42bd06a6/src/libcore/ptr/mod.rs:175
  24:     0x5644c01509ed - clippy_lints::utils::diagnostics::span_lint_and_then::haf05a40b33ba445d
                               at clippy_lints/src/utils/diagnostics.rs:124
  25:     0x5644c0153ada - clippy_lints::utils::diagnostics::span_lint_and_sugg::haec60d20d3ec9f97
                               at clippy_lints/src/utils/diagnostics.rs:167
  26:     0x5644bfd58f07 - clippy_lints::use_self::span_use_self_lint::he169aa60b50121cf
                               at clippy_lints/src/use_self.rs:67
  27:     0x5644bfd5a472 - <clippy_lints::use_self::UseSelfVisitor as rustc::hir::intravisit::Visitor>::visit_path::hdb008b09016b012f
                               at clippy_lints/src/use_self.rs:239

tesuji · 2019-10-29T03:16:10Z

The rustfmt is disabled. Give this another try
@bors r=phansch

bors · 2019-10-29T03:16:11Z

📌 Commit 84da79e has been approved by phansch

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors · 2019-10-29T03:16:18Z

⌛ Testing commit 84da79e with merge e2104d1...

bors · 2019-10-29T03:41:50Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing e2104d1 to master...

tesuji force-pushed the int-errexit branch 2 times, most recently from d21e823 to cb1f310 Compare October 24, 2019 03:25

phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Oct 24, 2019

flip1995 reviewed Oct 24, 2019

View reviewed changes

ci/integration-tests.sh Outdated Show resolved Hide resolved

tesuji force-pushed the int-errexit branch 3 times, most recently from 3d94045 to 18e80b8 Compare October 26, 2019 03:11

tesuji force-pushed the int-errexit branch from 18e80b8 to 62222c3 Compare October 26, 2019 03:24

tesuji changed the title ~~[WIP] fix clippy not run in some integration tests~~ Do not early exit if cargo clippy returns non-zero status code Oct 26, 2019

flip1995 reviewed Oct 26, 2019

View reviewed changes

ci/integration-tests.sh Show resolved Hide resolved

bors added a commit that referenced this pull request Oct 26, 2019

Auto merge of #4720 - lzutao:int-errexit, r=<try>

18ad60c

Do not early exit if cargo clippy returns non-zero status code changelog: none

tesuji force-pushed the int-errexit branch from b8c8b3d to d06a469 Compare October 26, 2019 18:27

tesuji force-pushed the int-errexit branch from d06a469 to 07119d3 Compare October 26, 2019 18:57

bors added a commit that referenced this pull request Oct 27, 2019

Auto merge of #4720 - lzutao:int-errexit, r=phansch

ae944a2

Do not early exit if cargo clippy returns non-zero status code changelog: none

tesuji force-pushed the int-errexit branch from 04a3293 to a9f221a Compare October 27, 2019 10:26

bors added a commit that referenced this pull request Oct 27, 2019

Auto merge of #4720 - lzutao:int-errexit, r=phansch

24a3199

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors added a commit that referenced this pull request Oct 27, 2019

Auto merge of #4720 - lzutao:int-errexit, r=phansch

bcd8f32

Do not early exit if cargo clippy returns non-zero status code changelog: none

tesuji mentioned this pull request Oct 27, 2019

ICE in use_self lints #4742

Closed

tesuji force-pushed the int-errexit branch 2 times, most recently from 9013562 to 84da79e Compare October 29, 2019 03:15

tesuji added 2 commits October 29, 2019 10:16

Early exit in integration tests

53f14ab

build: strip before caching in .cargo/bin

84da79e

bors added a commit that referenced this pull request Oct 29, 2019

Auto merge of #4720 - lzutao:int-errexit, r=phansch

e2104d1

Do not early exit if cargo clippy returns non-zero status code changelog: none

bors merged commit 84da79e into rust-lang:master Oct 29, 2019

tesuji deleted the int-errexit branch October 29, 2019 03:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not early exit if cargo clippy returns non-zero status code #4720

Do not early exit if cargo clippy returns non-zero status code #4720

tesuji commented Oct 23, 2019 •

edited

Loading

bors commented Oct 24, 2019

tesuji commented Oct 26, 2019

flip1995 commented Oct 26, 2019

bors commented Oct 26, 2019

tesuji commented Oct 26, 2019

bors commented Oct 26, 2019

flip1995 commented Oct 26, 2019

bors commented Oct 26, 2019

tesuji commented Oct 26, 2019 •

edited

Loading

tesuji commented Oct 26, 2019

tesuji commented Oct 26, 2019

phansch commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

phansch commented Oct 27, 2019

tesuji commented Oct 27, 2019 •

edited

Loading

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

tesuji commented Oct 27, 2019

tesuji commented Oct 27, 2019

bors commented Oct 27, 2019

tesuji commented Oct 27, 2019

tesuji commented Oct 29, 2019

bors commented Oct 29, 2019

bors commented Oct 29, 2019

bors commented Oct 29, 2019

Do not early exit if cargo clippy returns non-zero status code #4720

Do not early exit if cargo clippy returns non-zero status code #4720

Conversation

tesuji commented Oct 23, 2019 • edited Loading

bors commented Oct 24, 2019

tesuji commented Oct 26, 2019

flip1995 commented Oct 26, 2019

bors commented Oct 26, 2019

tesuji commented Oct 26, 2019

bors commented Oct 26, 2019

flip1995 commented Oct 26, 2019

bors commented Oct 26, 2019

tesuji commented Oct 26, 2019 • edited Loading

tesuji commented Oct 26, 2019

tesuji commented Oct 26, 2019

phansch commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

phansch commented Oct 27, 2019

tesuji commented Oct 27, 2019 • edited Loading

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

bors commented Oct 27, 2019

tesuji commented Oct 27, 2019

tesuji commented Oct 27, 2019

bors commented Oct 27, 2019

tesuji commented Oct 27, 2019

tesuji commented Oct 29, 2019

bors commented Oct 29, 2019

bors commented Oct 29, 2019

bors commented Oct 29, 2019

tesuji commented Oct 23, 2019 •

edited

Loading

tesuji commented Oct 26, 2019 •

edited

Loading

tesuji commented Oct 27, 2019 •

edited

Loading