Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deprecated lints don't expand #4757

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Fix Deprecated lints don't expand #4757

merged 4 commits into from
Nov 7, 2019

Conversation

evanjs
Copy link
Contributor

@evanjs evanjs commented Oct 31, 2019 •
edited by phansch
Loading

Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

fixes #4748

Unable to cargo test locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

2019-10-30_21:06:28

changelog: Show deprecated lints in lint documentation again

@evanjs
Fix rust-lang#4748 - Deprecated lints don't expand
94e3551 
- Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py
phansch
phansch approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with indents fixed

clippy_lints/src/deprecated_lints.rs Outdated Show resolved Hide resolved
@evanjs
Copy link
Contributor Author

evanjs commented Nov 2, 2019

Thanks! Didn't even think about the indents. Derp.

Some of the doc-comments now barely exceed 80 characters, but I wasn't sure of any line-break conventions, so I left those alone.

@evanjs
Copy link
Contributor Author

evanjs commented Nov 2, 2019

Pardon the noise. That's what I get for having multiple clippy repos on the same machine.

Checked against the live site and all the lints seem to be present and expandable.

@phansch
Copy link
Member

phansch commented Nov 3, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Nov 3, 2019

📌 Commit 8ca9c23 has been approved by phansch

@bors
Copy link
Contributor

bors commented Nov 3, 2019

⌛ Testing commit 8ca9c23 with merge d3302c2...

bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
d3302c2 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)
@bors
Copy link
Contributor

bors commented Nov 3, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Nov 3, 2019

@bors retry (amended the PR post with a changelog)

@bors
Copy link
Contributor

bors commented Nov 3, 2019

⌛ Testing commit 8ca9c23 with merge 04d8fca...

bors added a commit that referenced this pull request Nov 3, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
04d8fca 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@bors
Copy link
Contributor

bors commented Nov 3, 2019

💔 Test failed - checks-travis

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
@flip1995
Rollup merge of rust-lang#4757 - evanjs:issue/4748, r=phansch
53a99cd 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@flip1995 flip1995 mentioned this pull request Nov 7, 2019
Closed
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
@flip1995
Rollup merge of rust-lang#4757 - evanjs:issue/4748, r=phansch
2fed74e 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@flip1995 flip1995 mentioned this pull request Nov 7, 2019
Closed
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4790 - flip1995:rollup-8rnsng6, r=flip1995
f112422 
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4790 - flip1995:rollup-8rnsng6, r=flip1995
6eb40e0 
Rollup of 4 pull requests

Successful merges:

 - #4697 (restriction lint for `std::process::exit`)
 - #4757 (Fix Deprecated lints don't expand)
 - #4758 (`DecimalLiteralRepresentation` simplification)
 - #4769 (don't warn on CRLF in `with_newline` lints)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 8ca9c23 with merge 842cfb0...

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4757 - evanjs:issue/4748, r=phansch
842cfb0 
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 842cfb0 to master...

@bors bors merged commit 8ca9c23 into rust-lang:master Nov 7, 2019
@evanjs evanjs deleted the issue/4748 branch November 7, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint docs: Deprecated lints don't expand
3 participants
@evanjs @phansch @bors