Allow casts from the result of checked_abs to unsigned
#4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
JohnTitor
reviewed
Nov 5, 2019
tests/ui/cast.rs
Outdated
Comment on lines
50
to
54
| (-1i8).checked_abs() as u8; | ||
| (-1i16).checked_abs() as u16; | ||
| (-1i32).checked_abs() as u32; | ||
| (-1i64).checked_abs() as u64; | ||
| (-1isize).checked_abs() as usize; |
There was a problem hiding this comment.
checked_abs returns Option<T> so we should use unwrap or something else to get contained values.
There was a problem hiding this comment.
Thank you for the review, i will fix that
JohnTitor
added
S-waiting-on-author
flip1995
reviewed
Nov 8, 2019
|
triggering a new build |
flip1995
requested changes
Nov 12, 2019
There was a problem hiding this comment.
This #4764 (comment) code duplication should still be addressed.
chansuke
force-pushed
the
fix_checked_abs
branch
from
79ec213
to
c3b0ece
Compare
flip1995
approved these changes
Nov 18, 2019
|
@flip1995 Thank you!! |
|
@bors r+ rollup |
|
📌 Commit c3b0ece has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Nov 23, 2019
Allow casts from the result of `checked_abs` to unsigned Fixes rust-lang#4743.
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 6 pull requests Successful merges: - #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body) - #4764 (Allow casts from the result of `checked_abs` to unsigned) - #4766 (Fix false positive in derive_hash_xor_eq) - #4811 (Literal Representation Restructure) - #4820 (doc: fix the comment above the lint function) - #4830 (use more efficient code to generate repeated string) Failed merges: r? @ghost changelog: none
flip1995
reviewed
Nov 23, 2019
| // `abs` is an inherent impl of `i{N}`, so a method call with ident `abs` will always | ||
| // resolve to that spesific method | ||
| if_chain! { | ||
| if let ExprKind::MethodCall(ref path, _, _) = op.kind; | ||
| if path.ident.name.as_str() == "abs"; | ||
| if ["abs", "checked_abs"].contains(path.ident.name); |
There was a problem hiding this comment.
path.indent.name gives a type error
|
@bors r- |
bors
added a commit
that referenced
this pull request
Dec 12, 2019
…lse-positive, r=flip1995 Fix false positive with cast_sign_loss lint `cast_sign_loss` lint incorrectly suggests that the result of `checked_abs`, `rem_euclid` and `checked_rem_euclid` cannot be casted to an unsigned integer without loss. Fixes #4818 #4764 #4743 changelog: Fix false positives in `cast_sign_loss` lint
|
☔ The latest upstream changes (presumably #4883) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4743.