Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustup to rustc 1.40.0-nightly (50f8aadd 2019-11-07) #4788

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Rustup to rustc 1.40.0-nightly (50f8aadd 2019-11-07) #4788

merged 3 commits into from
Nov 7, 2019

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Nov 7, 2019 •
edited by flip1995
Loading

changelog: Deprecate [into_iter_on_array] lint

r? @phansch @oli-obk

flip1995
flip1995 approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with test changes reverted.

tests/ui/functions.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 mentioned this pull request Nov 7, 2019
Closed
@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 60f8acf has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 60f8acf with merge 76342b6...

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4788 - Manishearth:rustup, r=flip1995
76342b6 
Rustup to rustc 1.40.0-nightly (7a76fe7 2019-11-07)

changelog: none

r? @phansch @oli-obk
@bors
Copy link
Contributor

bors commented Nov 7, 2019

💔 Test failed - status-appveyor

tesuji
tesuji reviewed Nov 7, 2019
View reviewed changes
clippy_lints/src/attrs.rs Show resolved Hide resolved
clippy_lints/src/doc.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

I'm currently on the rustup fixes for rust-lang/rust#66180, btw

@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

Comment to 954eb83:

The new rustc lint covers all the test cases, that were removed in this commit.

@flip1995
Deprecate into_iter_on_array lint
08fd397 
This lint was uplifted/reimplemented by rustc.
Rustup to rust-lang/rust#66017
@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

@bors treeclosed=10 p=10

@flip1995 flip1995 changed the title Rustup to rustc 1.40.0-nightly (7a76fe76f 2019-11-07) Rustup to rustc 1.40.0-nightly (50f8aadd 2019-11-07) Nov 7, 2019
@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

@bors r+

Travis passed. Let's get this going.

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 08fd397 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 08fd397 with merge 7531a08...

bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #4788 - Manishearth:rustup, r=flip1995
7531a08 
Rustup to rustc 1.40.0-nightly (50f8aad 2019-11-07)

changelog: Deprecate [`into_iter_on_array`] lint

r? @phansch @oli-obk
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 7531a08 to master...

@bors bors merged commit 08fd397 into rust-lang:master Nov 7, 2019
This was referenced Nov 7, 2019
Merged
Closed
Closed
This was referenced Nov 7, 2019
Closed
Closed
Closed
@flip1995
Copy link
Member

flip1995 commented Nov 7, 2019

@bors treeclosed-

@tesuji
Copy link
Contributor

tesuji commented Nov 7, 2019

@bors treeclose-

@tesuji
Copy link
Contributor

tesuji commented Nov 7, 2019

@bors treeclosed- retry

@Manishearth
Copy link
Member Author

@lzutao you're not in the Clippy team so bors will ignore all your comments

@tesuji
Copy link
Contributor

tesuji commented Nov 7, 2019

It worth a try :p. Sorry but could you undo the treeclosed?

@Manishearth Manishearth deleted the rustup branch November 7, 2019 20:42
@Manishearth
Copy link
Member Author

@bors treeclosed-

@Manishearth
Copy link
Member Author

i thought flip had done it but might as well try again

@Manishearth
Copy link
Member Author

@bors treeclose-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesuji tesuji tesuji left review comments

@flip1995 flip1995 flip1995 approved these changes

@mati865 mati865 mati865 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @flip1995 @bors @tesuji @mati865