Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of Result::map_or #4848

Merged
merged 1 commit into from
Nov 28, 2019
Merged

make use of Result::map_or #4848

merged 1 commit into from
Nov 28, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Nov 25, 2019

Fixes #1590

changelog: none

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with rustup

@flip1995 flip1995 added the S-waiting-on-bors Status: The marked PR was approved and is only waiting bors label Nov 25, 2019
@Arnavion
Copy link
Contributor

Fixes #1590

@tesuji tesuji force-pushed the result-map_or branch 2 times, most recently from 59a6cdb to d0e0ffa Compare November 28, 2019 03:51
@phansch
Copy link
Member

phansch commented Nov 28, 2019

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Nov 28, 2019

📌 Commit d0e0ffa has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 28, 2019

⌛ Testing commit d0e0ffa with merge 7f745da...

bors added a commit that referenced this pull request Nov 28, 2019
make use of Result::map_or

Fixes #1590

changelog: none
@bors
Copy link
Contributor

bors commented Nov 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 7f745da to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend option-map-unwrap-or-else to Result
5 participants