Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP in manual_swap lint with slice-like types #4877

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Dec 3, 2019

Fixes #4853

changelog: Fix FP in [manual_swap] lint with slice-like types and make it auto applicable

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 3, 2019
@llogiq
Copy link
Contributor

llogiq commented Dec 3, 2019

LGTM

@bors r+

@bors
Copy link
Contributor

bors commented Dec 3, 2019

📌 Commit aa2381d has been approved by llogiq

@bors
Copy link
Contributor

bors commented Dec 3, 2019

⌛ Testing commit aa2381d with merge c66cca4...

bors added a commit that referenced this pull request Dec 3, 2019
Fix FP in manual_swap lint with slice-like types

Fixes #4853

changelog: Fix FP in [`manual_swap`] lint with slice-like types and make it auto applicable
@bors
Copy link
Contributor

bors commented Dec 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: llogiq
Pushing c66cca4 to master...

@bors bors merged commit aa2381d into rust-lang:master Dec 3, 2019
@flip1995 flip1995 deleted the manual_swap_4853 branch December 3, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive when swapping elements of a matrix
3 participants